Define all input validation consistently in the schema

wimski commented 3 years ago

The following situations occurred regarding input validation:

Some input only depended on schema restrictions (e.g. field: String!).
Some input used the @rules directive in the schema.
Some input used a validator in the mutation.

This PR remedies that by:

Only using the @rules directive in the schema thereby centralizing all validation definitions.
Validating all input fields regardless of schema restrictions, so any mutation can always assume that the expected input is present and valid.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 752642051

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/GraphQL/Mutations/Login.php	0	2	0.0%
<!--	Total:	0	2	0.0%	-->

Totals
Change from base Build 748412615:	0.0%
Covered Lines:	0
Relevant Lines:	84

💛 - Coveralls

daniel-de-wit commented 3 years ago

@wimski Thank you!!

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 752642051

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.0%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/GraphQL/Mutations/Login.php	0	2	0.0%
<!--	Total:	0	2	0.0%	-->

Totals
Change from base Build 748412615:	0.0%
Covered Lines:	0
Relevant Lines:	84

daniel-de-wit / lighthouse-sanctum

Define all input validation consistently in the schema #1

Pull Request Test Coverage Report for Build 752642051

💛 - Coveralls

Pull Request Test Coverage Report for Build 752642051

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls