daniel-de-wit / lighthouse-sanctum

Laravel Sanctum support for Laravel Lighthouse
MIT License
56 stars 9 forks source link

Fix tests that fail because validation error message changes in laravel/laravel 8.5.21 #63

Closed dennis-koster closed 3 years ago

dennis-koster commented 3 years ago

When checking out this package and running the tests, some assertions on URL validity error messages fail, if the installed version of orchestra/testbench-core is equal or higher than ^v6.23.1, because of this change: https://github.com/orchestral/testbench-core/commit/f189915445275e511ae12cef356246bee8faca6f

Or the laravel/laravel equivalent: https://github.com/laravel/laravel/commit/866589128430c55385cb13ddae0061c628245be2

To fix this, I have added a more explicit requirement for orchestra/testbench-core in the composer.json file. This is, unfortunately, a breaking change.

wimski commented 3 years ago

@daniel-de-wit do you have an issue with this?

@dennis-koster 8.5.21 is sufficient https://github.com/laravel/laravel/releases/tag/v8.5.21

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1098041157

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Totals Coverage Status
Change from base Build 1025809167: 0.0%
Covered Lines: 256
Relevant Lines: 257

💛 - Coveralls