search

daniel-de-wit / lighthouse-sanctum

Laravel Sanctum support for Laravel Lighthouse
MIT License
56 stars 9 forks source link

Wrong config value usage; fixes #80 #81

Closed xorinzor closed 2 years ago

xorinzor commented 2 years ago

Changes the files edited in PR #77 that make use of lighthouse-sanctum.identification.user_identifier_field_name to use lighthouse-sanctum.user_identifier_field_name instead (as per readme + config file)

Fixes #80

daniel-de-wit commented 2 years ago

I missed that mistake, thank you 👍

wimski commented 2 years ago

Should've also integration tested this update using the actual config.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 2536117549

Totals Coverage Status
Change from base Build 2534619463: 0.0%
Covered Lines: 217
Relevant Lines: 218
💛 - Coveralls
daniel-de-wit commented 2 years ago

I've added an integration test for this: #82

coveralls commented 2 months ago

Pull Request Test Coverage Report for Build 2536117549

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

Totals Coverage Status
Change from base Build 2534619463: 0.0%
Covered Lines: 217
Relevant Lines: 218
💛 - Coveralls