Multi-locale placeholders, resolving to keys, nested placeholders

daniel-frak commented 3 years ago

Change behavior of LocalizedDummyDefinitions::resolve to include resolving to lists of keys, update ExpressionResolver Javadoc accordingly
Allow resolving nested placeholders with ExpressionResolver::resolve (#{path.to.key1.#{path.to.key2}})
Introduce multi-locale placeholders (#{{path.to.key}})
Document new features in Markdown and Javadoc
Change some references of key to path in Javadoc
Refactor DefaultExpressionResolver
Add static import for Arrays in DefaultExpressionResolverTest
Expand LocalizedDummyDefinitionsMap and DefaultExpressionResolver tests to check multi-locale resolving
Fix bug with nested single-locale placeholders being resolved in a different locale than their parent expressions
Fix bug where trying to resolve an unresolvable expression would sometimes result in an ArrayIndexOutOfBoundsException
Make LocalizedDummyDefinitionsMap final
Replace all mentions of a parser with 'expression resolver'
Clarify removal of unresolvable placeholders from expressions
Unify path.to.key / key.path / key.path references

sonarcloud[bot] commented 3 years ago

SonarCloud Quality Gate failed.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

little-pinecone commented 3 years ago

A short summary of things to consider for this PR:

Unify the naming for Parser/ExpressionResolver
Unify definition.path/key.path
Think about dividing the DefaultExpressionResolverTest into smaller classes
Fix resolving definition key from multiple locales
Think about replacing in order with preserving order in the DefaultExcpressionResolver javadoc
Think about minor changes in the ExpressionResolver javadoc
Test resolving #{key1}.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

daniel-frak / dummy4j