search

daniel-j-h / libosrmc

Pure C bindings for libosrm
MIT License
18 stars 8 forks source link

Added trip service #20

Open srimaln91 opened 4 years ago

daniel-j-h commented 4 years ago

Hey thanks for this 🥳 I'll come back to you on Monday with a review 🤗

On May 1, 2020 1:43:01 PM UTC, "H.M.S.Nishantha" notifications@github.com wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/daniel-j-h/libosrmc/pull/20

-- Commit Summary --

  • Added trip service

-- File Changes --

M libosrmc/osrmc.cc (130) M libosrmc/osrmc.h (21)

-- Patch Links --

https://github.com/daniel-j-h/libosrmc/pull/20.patch https://github.com/daniel-j-h/libosrmc/pull/20.diff

daniel-j-h commented 4 years ago

Looks good overall; I left some smaller comments inline.

General note: the trip service in osrm is pretty basic. We should probably add a note to the readme pointing the user e.g. to https://github.com/mapbox/node-or-tools which works on top of the distance table.

daniel-j-h commented 4 years ago

@srimaln91 do you still want to run out the suggested changes and then bring it in?