search

daniel-j / send2ereader

A service for sending ebooks to a Kobo or Kindle ereader through the built-in browser
https://send.djazz.se
MIT License
341 stars 54 forks source link

fixed book in chinese title failed downloading in kobo issue #15

Closed adaxz closed 9 months ago

adaxz commented 11 months ago

Hi Daniel

I came across an issue while using this tool. It appears that any book with book titles in Chinese is currently not downloadable in Kobo. To address this issue, I replaced the original file name in Chinese with a "pinyin" version, which is a romanized representation of the Chinese title. (any none Chinese title name will remain the same with the romanizeChinese function )

This modification ensures compatibility and allows users to download books with Chinese titles successfully. I believe this enhancement will greatly improve the user experience for Chinese readers.

Please review my changes and let me know if there are any further adjustments or suggestions. I'm open to feedback and eager to collaborate on resolving this issue.

Thank you for your attention to this matter.

Best regards, Ada

daniel-j commented 9 months ago

Hi and thanks for the pull request! I modified it to support more languages and to fit the coding style.