daniel-j / send2ereader

A service for sending ebooks to a Kobo or Kindle ereader through the built-in browser
https://send.djazz.se
MIT License
341 stars 54 forks source link

Option to disable transliteration #24

Closed shihong5858 closed 1 month ago

shihong5858 commented 4 months ago

First of all, thank you so much for providing such a great online tool to help Kobo users to transfer e-books in a convenient way.

One issue troubles me a lot by using the tool, is that when I transfer Chinese/Japanese books, their name would be translated to English form and it's really hard to read/find when I connect the device using USB.

I checked the code and found it's processed by the transliteration plugin, I assume it is to help to convert file names with proper encoding. Therefore I wonder if the web tool can provide an additional option to bypass this step so it would be super helpful to non-Latin language users.

Thank you.

daniel-j commented 3 months ago

Hello and thank you for your input. I think I added transliteration because Kobo or Kindle browser only can download files with some characters in filename. If filename would contain an unexpected glyph it would silently fail. Been a while since I added that feature, but I can take a closer look. I thought transliteration was better than just stripping the glyphs, in case the filename only contained kanji characters for example nothing but extension would remain.

shihong5858 commented 3 months ago

Hmmm I see. From I just tested the Kobo seems able to accept non-Latin characters:

tempImagetM9sqo

I used a Notion link so there were gibberish UUID in the file now. I do understand there are cases that filenames with glyphs would cause issues. However if possible, it would be greatly helpful for non-Latin language users to have an option (even its' not by default checked) to bypass the transliteration process.

daniel-j commented 1 month ago

Non-latin should now work on Kobo devices! Also made it to a toggleable option. On Kindle non-latin characters gets stripped. https://github.com/daniel-j/send2ereader/commit/c1b6f9d3eab43df60a1e1c74abeede37b3f16976