Thanks for you work on the project. Some changes that I've made to suit my situation and preferences might be of interest to others. Not looking for another fork to be maintained, I'm hoping you'll consider merging these.
If there's anything that you'd like to see changed in the PR, I'd be happy to consider and discuss.
Commit messages should speak for themselves, though here's some of my rationale and considerations.
Instead of waiting UPDATE_INTERVAL start reading the P1 data immediately after boot. This is especially handy while testing.
Move println next to action
Easy to understand, non-functional change to make the next one more easy to understand in the diff.
Make RX inversion configurable
My hardware was already built based on other projects online and uses a transistor to invert the serial signal. This change accommodates for such devices, while keeping the default unchanged.
Set hostname for DHCP requests
Setting the host name on WiFi includes it in DHCP requests enabling dynamic DNS updates.
Thanks for you work on the project. Some changes that I've made to suit my situation and preferences might be of interest to others. Not looking for another fork to be maintained, I'm hoping you'll consider merging these.
If there's anything that you'd like to see changed in the PR, I'd be happy to consider and discuss.
Commit messages should speak for themselves, though here's some of my rationale and considerations.
Nicer format incoming messages
New
Old
Start reading immediately after boot
Instead of waiting
UPDATE_INTERVAL
start reading the P1 data immediately after boot. This is especially handy while testing.Move println next to action
Easy to understand, non-functional change to make the next one more easy to understand in the diff.
Make RX inversion configurable
My hardware was already built based on other projects online and uses a transistor to invert the serial signal. This change accommodates for such devices, while keeping the default unchanged.
Set hostname for DHCP requests
Setting the host name on
WiFi
includes it in DHCP requests enabling dynamic DNS updates.