search

daniel-kukiela / nmt-chatbot

NMT Chatbot
GNU General Public License v3.0
385 stars 212 forks source link

No modded_inference.py #103

Open jinius17 opened 5 years ago

jinius17 commented 5 years ago

Hello,

I know you removed it due to compatibility issues, but is there a chance to upload to so we can try to modify it?

Thanks

daniel-kukiela commented 5 years ago

There is a branch of a code used by sentdex in his tutorials. It's in README :)

jinius17 commented 5 years ago

Ok. Thanks a lot. I actually modified your own code and managed to get around the same results. Shall I create a pull request?

daniel-kukiela commented 5 years ago

I'm not going to mainain that with newer chatbot releases. Also I'm not sure why you need modded inference with newest code.

jinius17 commented 5 years ago

My modified code just allows the highest scored answers. Basically I only present your GREEN answers.

daniel-kukiela commented 5 years ago

So calling inference directly is meant only for testing purposes. During testing you want to see all answers anyway. To be honest I see no reason in modifying that.

Usually you are going to import chatbot, then you are receiving some dictionary as a result with scores and an index of an answer (configurable in settings).