search

daniel-lewis-ab / litegraph.js

A graph node engine and editor written in Javascript similar to PD or UDK Blueprints, comes with its own editor in HTML5 Canvas2D. The engine can run client side or server side using Node. It allows to export graphs as JSONs to be included in applications independently.
MIT License
11 stars 2 forks source link

Question about branches and PR #21

Open liusida opened 3 weeks ago

liusida commented 3 weeks ago

Hi guys,

I saw that @daniel-lewis-ab is working on the reversion and @atlasan is working on forwardcompatible. And I've sumitted a PR to the master. Is master the branch I should PR to? Did I do it right? Or, should I join @atlasan to fix things on forwardcompatible?

I need some suggestion. Thanks!

liusida commented 3 weeks ago

And what does the phrase forward compatible mean? Does it mean that it has the latest featuers and will be merged to master progressively?

atlasan commented 3 weeks ago

Hi @liusida, good to see you here ^ ^ I chose the name for the temporary branch I'm working on. Surely the intention is to be compatible and forward looking ^ ^ Please feel free to join, need some hands in testing, cleaning, and improving.

liusida commented 3 weeks ago

Hi @liusida, good to see you here ^ ^ I chose the name for the temporary branch I'm working on. Surely the intention is to be compatible and forward looking ^ ^ Please feel free to join, need some hands in testing, cleaning, and improving.

Sounds like a plan. Do you have any specific tasks that I can work on? I can try one of them first.

liusida commented 3 weeks ago

And, what do you think about the PR #19, since that PR can make litegraph.js runnable in plain html, and we won't need to start a http server for the development any more. Should I PR to your branch instead of the master?

liusida commented 3 weeks ago

I've just learned the basics of jest. And I think I can do some testing to start with. What's your opinion towards using ChatGPT to accelerate the writing of test cases?

atlasan commented 3 weeks ago

Sounds like a plan. Do you have any specific tasks that I can work on? I can try one of them first.

I would say:

And many more:

atlasan commented 3 weeks ago

I've just learned the basics of jest. And I think I can do some testing to start with. What's your opinion towards using ChatGPT to accelerate the writing of test cases?

Nothing against as long as nice and working ^_ ^

What about making workflows that are tests themselves? The way to check at high level the system could be to use it for real. A complex stepped demo would eventually cover two interests.

liusida commented 3 weeks ago

making workflows that are tests themselves

What a brilliant suggestion~ xD

daniel-lewis-ab commented 3 weeks ago

Any features you want to add are good on forwardcompatible, that's basically forked off of reversion AFAIK.

My thought is that we're going to get reversion caught up, and then start porting over any features we want one at a time so that there's some discipline in how they're integrated while still allowing us to dev freely. Both Atlasan and I have trouble doing just one thing at a time so the commits and versioning are clean.

On Fri, Jun 7, 2024 at 1:14 AM Liu Sida @.***> wrote:

Hi guys,

I saw that @daniel-lewis-ab https://github.com/daniel-lewis-ab is working on the reversion and @atlasan https://github.com/atlasan is working on forwardcompatible. And I've sumitted a PR to the master. Is master the branch I should PR to? Did I do it right? Or, should I join @atlasan https://github.com/atlasan to fix things on forwardcompatible?

I need some suggestion. Thanks!

— Reply to this email directly, view it on GitHub https://github.com/daniel-lewis-ab/litegraph.js/issues/21, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC36LNYCAODAOFQKXVTY2QDZGFMUTAVCNFSM6AAAAABI6DHHZSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZTSNZWGA3TEMA . You are receiving this because you were mentioned.Message ID: @.***>

liusida commented 3 weeks ago

think about the best way to allow different version of the library in ComfyUI ( I was imagining a setting in there where to specify the name of the folder/file to be included. This would help testing and switching to pre-release or custom UIs easily. eg. clone the repo in a folder and specify that folder name in the ComfyUI settings

Yeah. I naively thought that compiling this project into a litegraph.core.js file and replace the original one in ComfyUI would automatically bring new features to ComfyUI. (I've actually tried, but it doesn't work...)

How do you do this manually @atlasan ? Can the current forwardcompatible branch be applied to current ComfyUI?

I'll start a new issue on this #22.