search

daniel-lundin / react-dom-confetti

Trigger confetti explosions on state transitions
623 stars 30 forks source link

Lag in the Confetti explosion #13

Closed panmona closed 6 years ago

panmona commented 6 years ago

I use this in an application of mine and we noticed quite a bit of lag in the confetti explosion. See the gif I attached: 2018-04-25 18 09 05

I hope that you can resolve this issue.

daniel-lundin commented 6 years ago

It's hard to tell from a gif, but how are the other animations implemented? This library only animates transform an opacity so it should be quite performant, but if the other animations trigger layouts it will probably interfere with the explosion. Can you post a minimal reproducible codepen or similar?

panmona commented 6 years ago

@daniel-lundin I'll look into it.

panmona commented 6 years ago

Won't have time for that in the next time, I'll close this for now.

panmona commented 5 years ago

Maybe instead of using dom elements you could use CSS Houdini. Think this will speed things up a lot