updated the types for the ConfettiConfig object

daniel-lundin / react-dom-confetti

Trigger confetti explosions on state transitions

624 stars 30 forks source link

Closed AdiBev closed 4 years ago

AdiBev commented 4 years ago

The existing types for the ConfettiConfig object doesn't match with the current one. I'm proposing this changes.

AdiBev commented 4 years ago

Updated the types for ConfettiConfig object.

daniel-lundin commented 4 years ago

Nice that you added the missing keys, but why should they be strings and not numbers?

daniel-lundin commented 4 years ago

Had a similar PR that I just merged, thanks anyway!