search

daniel-lynch / daniel_lynch.passbolt

Passbolt Ansible collection
https://galaxy.ansible.com/daniel_lynch/passbolt
GNU General Public License v3.0
6 stars 7 forks source link

Create and Update modules insert the entry name into the password field #1

Closed TheQueasle closed 2 years ago

TheQueasle commented 2 years ago

For the create and update modules, the mapping seems to be off for the passwords.

https://github.com/daniel-lynch/daniel_lynch.passbolt/blob/main/plugins/modules/create_password.py#L114 https://github.com/daniel-lynch/daniel_lynch.passbolt/blob/main/plugins/modules/update_password.py#L128

If I use the code as-is, when a new entry is created or an entry is updated in passbolt, the password field is added with the name of the entry instead of the password.

If I change those lines to the following, it works as expected.

password = module.params['password']
daniel-lynch commented 2 years ago

Good catch @TheQueasle! Thanks for the PR.