search

daniel-lynch / daniel_lynch.passbolt

Passbolt Ansible collection
https://galaxy.ansible.com/daniel_lynch/passbolt
GNU General Public License v3.0
6 stars 7 forks source link

fixes type mismatch issue for verify parameter #9

Closed lukasskopos closed 1 year ago

lukasskopos commented 1 year ago

The parameter verify is defined as type str. When verify is set in a task it will be a string and interpreted as a ca path. https://github.com/daniel-lynch/daniel_lynch.passbolt/blob/main/plugins/modules/delete_password.py#L94

The python request library expects a bool or a string (path). https://github.com/psf/requests/blob/main/requests/api.py#L39

This fix adds a type cast in case a bool in form of a str is given like "true", "false", "True", "False".

daniel-lynch commented 1 year ago

@lukasskopos Very clean, thank you!