search

daniel-nagy / md-data-table

Material Design Data Table for Angular Material
MIT License
1.9k stars 519 forks source link

progress bar not hide when promise has been reject #316

Closed zack24q closed 8 years ago

zack24q commented 8 years ago

Hi I modified demo code to reproduce this behavior.Please see this example http://codepen.io/anon/pen/WwxXLL?editors=1010. Is this default behavior or bug? I think when table's promise getting rejected, the progress bar should be hidden automatic and the programmer can prompt user what happened.

zack24q commented 8 years ago

seems modify this function can fix this problem if it is a bug.

daniel-nagy commented 8 years ago

I believe you are right, I think I need to change line 80 to

queue[0].finally(function () {
  queue.shift();
  resolvePromises();
});
daniel-nagy commented 8 years ago

Should be fixed now.

zack24q commented 8 years ago

Thanks!