daniel-nagy / md-data-table

Material Design Data Table for Angular Material
MIT License
1.9k stars 520 forks source link

Convert mdTableProgress class directive into an attribute directive #516

Closed christophercr closed 7 years ago

christophercr commented 7 years ago

Hi,

I'm currently using md-data-table and it's awesome. However, I want now to upgrade to Angular 1.5.9+ which has some performance enhancements and one of those enhancements is the possibility to disable the compilation of class directives and comment directives (technically these should not be used anymore).

So now I noticed that there is one of these directives in md-data-table: the mdTableProgress is a class directive! So I think it is a good idea to convert it into an attribute directive so the impact will be minimal.

What do you think? I'll try to make a PR for this...