search

daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)
http://mesa3d.org
135 stars 3 forks source link

Dragon Quest XI - black sky corruption (aco-navi branch) #139

Closed aqxa1 closed 4 years ago

aqxa1 commented 5 years ago

Dragon Quest XI has a corrupted sky bug in some circumstances with aco-navi branch. Game also randomly hangs, but I'll leave that to another issue report.

Screenshots ACO: ACO screenshot

LLVM: LLVM screenshot

RenderDoc capture: Renderdoc capture

System information:

aqxa1 commented 5 years ago

Possible workaround is to set RADV_DEBUG=nohiz (looked to work at least once). But I haven't been able to reproduce again since it keeps GPU hanging on launch (even with CS disabled).

aqxa1 commented 5 years ago

Random hangs look to be fixed for this game with LLVM in latest mesa-git. If the ACO hangs were caused by the same issue, it might be worth rebasing against master.

Venemo commented 5 years ago

Thanks for the bug report. Can you please test with the latest aco-navi branch? Also please make sure to add RADV_DEBUG=nongg.

aqxa1 commented 5 years ago

I tested it and the corrupted sky issue is fixed at least. It's still semi-randomly hanging, but it looks to be happening with LLVM as well. It did seem to work a few days ago, so it might be a kernel issue.

aqxa1 commented 5 years ago

Okay, so I played the game for a couple of hours with LLVM without any hangs, so the issue does now appear to be limited to ACO. I'm not sure why it was happening with LLVM before. All I can think is that I was accidentally forcing ACO on mainline mesa-git, but I would assume that isn't available for Navi yet anyway?

Venemo commented 4 years ago

We're aware of the hang issue with Dragon Question XI but it is very likely to be unrelated to the shader compiler. We had a conversation yesterday about this, and the game hangs for us with LLVM as well.

aqxa1 commented 4 years ago

No worries, I'm the user that reported the issue on the mainline Mesa tracker, so I'm in agreement there. I do feel like ACO triggered the hangs more easily, but it might have just been a coincidence.

Venemo commented 4 years ago

@aqxa1 If you have time for it, I'd appreciate if you could test on my latest aco-navi branch. There have been a good number of fixes since your last try.

aqxa1 commented 4 years ago

@Venemo Just tested it. No GPU hangs in Sniflheim City, but they remain in Laguna di Gondalia.

ACO has the same draw-in/pop-in rendering issues as LLVM as well:

DQXI - rock from distance

DQXI - rock from close-up

Note how the snow covering on the rock disappears as you get close to it.

Venemo commented 4 years ago

@aqxa1 I had the opportunity to try Dragon Quest XI today. I couldn't reproduce the black sky problem. Unfortunately I haven't reached any area of the game with snow, so not sure about that one. Can you give us a save game with which to reproduce the issue?

aqxa1 commented 4 years ago

@Venemo The black sky problem has been fixed for a while.

dqxi-saves.zip

One of the included saves is at "Sniflheim - Campsite" and should show the problem.

pendingchaos commented 4 years ago

Closing this since the last issue (the snow glitch) seem to be resolved: https://gitlab.freedesktop.org/mesa/mesa/issues/2233