daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)
http://mesa3d.org
135 stars 3 forks source link

Battlefront 2 (2017) graphical corruption #147

Closed ptkato closed 4 years ago

ptkato commented 5 years ago

The game only crashes on specific maps, it seems to happen with 100% consistency on Capital Supremacy's Felucia, Kashyyyk and Genosis, the furtherest I could get into it was 5~10 seconds of the initial cinematic, if I join and it's in the middle of the match, it crashes when I pick a class and go to the pick a spawn screen. However, it doesn't crash in the ship phase, I can join the game then just fine, and it plays ok until it goes back to the ground phase, which is followed by a crash.

One thing about those maps is that I can play them if they're in Galactic Assault or Arcade.

Software information

Battlefront 2, Origin version, all the video options set to low.

System information

This issue was originally reported at DXVK's issue tracker.

daniel-schuermann commented 5 years ago

Hi, thx for the report. Does this issue also happen with RADV_PERFTEST=llvm? Would you be able to create a debug build of aco and provide the stderr output?

ptkato commented 5 years ago

It doesn't happen on LLVM, however the game has massive hangs without ACO, which makes it unplayable.

I'm using Lutris, which gobbles up the stderr, so the output might have some unrelated things: https://paste.ubuntu.com/p/WmMMTvKjZ7/

daniel-schuermann commented 5 years ago

Thx! We have an idea about where the bug is now, but we'll probably need a renderdoc capture to be able to replay it. Would you be able to start the game using llvm and try to capture a moment which makes aco fail? (You can check on being successful by opening the capture with aco, renderdoc should crash as well in this case)

ptkato commented 5 years ago

What do you mean by "start the game using llvm and try to capture a moment which makes aco fail"?

Is that just use LLVM instead and capture the moment where ACO would crash, if it were being used instead?

Edit: nevermind that, now I understand what you mean.

ptkato commented 5 years ago

I don't think I'd be able to do a renderdoc capture, I couldn't manage to launch Origin through a 64 bit wine executable and 32 bit wine just crashes, since it seems that renderdoc doesn't support 32 bit under Linux.

daniel-schuermann commented 4 years ago

@ptkato Oh yeah, that's a bit unfortunate. Maybe try https://gitlab.freedesktop.org/mesa/vkpipeline-db ? This let's you dump the shaders while playing and we should be able to replay them locally. I'd expect this to be enough as it isn't a rendering bug but just a shader not compiling. Maybe send me a link with the uploaded pipelines instead of posting them here (not all publishers like seeing their shaders dumped somewhere).

pendingchaos commented 4 years ago

I think you'll have to use LLVM in the map that ACO would crash with when capturing the pipelines, by the way.

ptkato commented 4 years ago

@daniel-schuermann where can I send you the link?

I sent it to you on freenode, if that's ok.

daniel-schuermann commented 4 years ago

Thx, the broken shader is indeed part of the collection. We'll keep you posted.

daniel-schuermann commented 4 years ago

Can you confirm if the issue is fixed with the latest update?

ptkato commented 4 years ago

Alas, I can't. The game is crashing to desktop the second I open it, in the first loading screen. However I don't think it's related to ACO, since it happens on LLVM too.

gort818 commented 4 years ago

@ptkato Yeah I tried to test it as well but cannot even load the game atm.

gort818 commented 4 years ago

@ptkato I got it running with https://github.com/Tk-Glitch/PKGBUILDS/releases/tag/4.19.r0.g1f775840

I will be testing if there are any crashes.

gort818 commented 4 years ago

Ok so there is no way to pick exactly what maps on Capital Supremacy.. unfortunately didn't get any of those maps.. but so far running smooth about 70-80 fps on ultra with ryzen 3700x and vega56.

There are some strange graphics glitches on certain maps I will make another report.

daniel-schuermann commented 4 years ago

@gort818 Would you retest if the corruption is still visible? We had some bug fixes which affected some of the SW:BF2 shaders, which means that there is the possibility that they have been fixed. If these are still visible, would you be able to grab a renderdoc capture of the scene? Thx in advance

pendingchaos commented 4 years ago

The bug fix hasn't been upstreamed yet btw: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2945

It's in this github repo though

EDIT: it's now upstreamed

gort818 commented 4 years ago

@daniel-schuermann yes definitely , it only happens on certain maps and the game doesn't let you chose maps. I will try this week, thanks!

gort818 commented 4 years ago

@daniel-schuermann So I played for a few hours on many different maps, everything seems to be working fine.

pendingchaos commented 4 years ago

Thanks, I'll be closing this issue