search

daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)
http://mesa3d.org
135 stars 3 forks source link

The Surge (378540) freezes and artifacts #150

Closed AwesamLinux closed 4 years ago

AwesamLinux commented 4 years ago

Describe the bug The Surge works fine with ACO until the second area (where the actual game begins), then the game is practically unplayable because it freezes frequently a couple of seconds. (as was mentioned on ValveSoftware/Proton#410)

Notice the performance here (ACO left) llvm_aco

There is also artifacts that look like lines that shoot accross the screen, as pictured below: surge

What I think is happening here is that it is the rendering of the sparks from the flying drone robots are glitching. Also these flying drones are not present in the introduction area, so maybe that is why there was no problems in there.

I have also tried with RADV_PERFTEST=llvmvs but that made no difference.

steam-378540-proton-4.11-7-aco.log.zip steam-378540-proton-4.11-7-llvm.log.zip

RenderDoc capture: Renderdoc 1.4 captures, providing two. Both grabbed using LLVM because I could not get it to capture with ACO.

https://drive.google.com/open?id=1naduFlnFnya1Tdvnv78lNhxfRCGG23KM https://drive.google.com/open?id=17Hz_CHwn8MlIHv7BTHcTuayvdpJ5YtHf

The first one is of the overall scene. And the second one with a close look at those flying drones and their sparks.

System information:

system_info.txt

Additional context I believe this problem did not exist when I tried it with ACO back in Jul 10 (I posted in the benchmark thread). I'm pretty sure I had tried this area too of the game without issues.

pingubot commented 4 years ago

I can confirm the issue.And it is definitively a regression, the surge worked fin in the past, not so long ago. I also have a vega 56.

AwesamLinux commented 4 years ago

System Information

Retest Compatibility Report

Tried this with the latest driver from ernstp PPA, and now the performance is good. But the graphical glitches remains, clouds flickering and lines/artifacts.

Here is a short screen capture of this: surge.mp4.zip system_info.txt

pingubot commented 4 years ago

I can confirm that perf issue is fixed with fe930ad92ab887ff1c1bb2779d9b5c0fc6c87700, but the flickering issue which is shown in @AwesamLinux video is there. This also is a regression, the surge worked perfect in the past.

pingubot commented 4 years ago

Sadly still an issue with commit 3b06b512c769301058f128cdd5b7a2ddc9584e7d

daniel-schuermann commented 4 years ago

We had some similar issue in Shader of the Tomb Raider. Would you check if the issue is still present with the current driver? If so, would you check if the issue is also present in upstream and try to get a capture of it? I tested both provided captures, and one of them just hangs with LLVM and with ACO while the other renders the same for me.

pingubot commented 4 years ago

@daniel-schuermann After removing shader caches i was able to start the game with the newest version. I still get the strange flickering, but i also get it with: RADV_PERFTEST=llvm %command%. In addition i also see the issue with my distro provided mesa radv 19.2.2 .

Edit: I also see the issue with amdpro (19.30) and amdvlk (2019q36)

AwesamLinux commented 4 years ago

System Information

system_info.txt

Retest Compatibility Report

I tried the game again with these two drivers:

(Hope these are recent enough, I always run into issues trying to compile the drivers myself :smile:)

I was able to capture with ACO enabled this time, this is how it looked for me:

steam-378540-proton-oibaf-4.11-8-aco.log.zip steam-378540-proton-oibaf-4.11-8-llvm.log.zip steam-378540-valve-proton-4.11-8-aco.log.zip steam-378540-valve-proton-4.11-8-llvm.log.zip

With LLVM I did not see any problems, the game was rendered correctly. But with ACO there is glitches like these: Screenshot from 2019-11-11 23-52-21 :point_up: There is a box in a darker shade to the left Screenshot from 2019-11-12 00-14-13 :point_up: The dust cloud to the right has no transparency

Captures: https://drive.google.com/open?id=1OLkNnnYfaREoWkN8aphpRlGJjdyHZR3L https://drive.google.com/open?id=1j5wS5TJxUF7_qqTpVXAq6yXvSF8X8j16

pingubot commented 4 years ago

@AwesamLinux is that grey bar in your first screenshot also changing the size and flickering ?

AwesamLinux commented 4 years ago

@pingubot yea it flickers and changes in size when looking around.

pingubot commented 4 years ago

Interesting, I tried again and that also happens for me with the other drivers as mentioned.

AwesamLinux notifications@github.com schrieb am Di., 12. Nov. 2019, 20:18:

@pingubot https://github.com/pingubot yea it flickers and changes in size when looking around.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daniel-schuermann/mesa/issues/150?email_source=notifications&email_token=AIPVS47NKUMB3UM4CEJODBLQTL6QVA5CNFSM4I74EQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOED3TKFY#issuecomment-553071895, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPVS427WTFWT7EPJLL2NLDQTL6QVANCNFSM4I74EQLA .

daniel-schuermann commented 4 years ago

Unfortunately, both renderdoc captures give me the exact same picture with LLVM and ACO. This can mean anything... It could be baked textures in the capture, a mesa regression or DXVK. Best way to figure what it is would be to find the working combination and bisect from there.

doitsujin commented 4 years ago

FWIW I cannot reproduce the problem on Polaris.

AwesamLinux commented 4 years ago

I have now a RX 5700 GPU and with this setup I'm seeing same glitch using both LLVM and ACO with Proton 4.11-11. But the problem goes away if hitting escape once to bring up the pause/options menu and then resuming the game!

The glitch occurs at the area where the actual gameplay starts: 20200107220209_1 :point_up: Here is the same glitch using LLVM, shadow like bar that flicker accross the screen.

I did some testing to try and narrow this down

Proton DXVK Compiler Worked?
4.2-9 1.2.1 ACO SUCCESS
4.2-9 1.2.1 LLVM SUCCESS
4.2-9 1.5 ACO SUCCESS
4.2-9 1.5 LLVM SUCCESS
4.11-11 1.2.1 ACO FAIL
4.11-11 1.2.1 LLVM FAIL
4.11-11 1.3.4 ACO FAIL
4.11-11 1.3.4 LLVM FAIL
4.11-11 1.4.5 ACO FAIL
4.11-11 1.4.5 LLVM FAIL
4.11-11 1.4.6 ACO FAIL
4.11-11 1.4.6 LLVM FAIL
4.11-11 1.5 ACO FAIL
4.11-11 1.5 LLVM FAIL

So the issue does not occur at all with Proton 4.2-9, but with 4.11-11 it occurs regardless of DXVK version or if using ACO or LLVM. I'm thinking ACO is not the problem considering I'm seeing this with LLVM too with the RX 5700

System Information

steam-378540-logs.zip system_info.txt

pingubot commented 4 years ago

@AwesamLinux many thx for your test. I also don't notice the black bars anymore using proton 4.2.9 instead of 4.2.11 (dxvk version kept identical) . But with latest aco (7b444ba5ef1818f81c1892c5babd02ed18186b02) now have issues with sandstorms. Can you see if you also have graphical corruptions (the sky is flickering with grey squares, hard to describe) if a sandstorm is happening ? Sadly i am not able to screenshot the issues, as it doesn't show up on a screenshot. That issues does not show up with radv llvm or amd-pro.

NTMan commented 4 years ago

Folks, please see my report https://gitlab.freedesktop.org/mesa/mesa/issues/2267

With Proton 4.2.9 the walls and characters are gone Demonstration: https://youtu.be/8uQLsVwvzQE

pingubot commented 4 years ago

Can you try Proton 4.2.9 but Use a more up2date dxvk as we do ? For me 4.2.9 works beside the sandstorm issue

Mikhail notifications@github.com schrieb am Mi., 8. Jan. 2020, 20:55:

Folks, please see my report https://gitlab.freedesktop.org/mesa/mesa/issues/2267

With Proton 4.2.9 the walls and characters are gone Demonstration: https://youtu.be/8uQLsVwvzQE

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daniel-schuermann/mesa/issues/150?email_source=notifications&email_token=AIPVS43KXEMBI2QGSRIZ72TQ4YVTVA5CNFSM4I74EQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINYXCA#issuecomment-572230536, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPVS47AXASWTRMT2UZW4ITQ4YVTVANCNFSM4I74EQLA .

NTMan commented 4 years ago

Can you try Proton 4.2.9 but Use a more up2date dxvk as we do ? For me 4.2.9 works beside the sandstorm issue

Which DXVK do you use? latest?

pingubot commented 4 years ago

I used a 1.4.4 Version but you might want to try the latest Release.

Mikhail notifications@github.com schrieb am Mi., 8. Jan. 2020, 21:06:

Can you try Proton 4.2.9 but Use a more up2date dxvk as we do ? For me 4.2.9 works beside the sandstorm issue

Which DXVK do you use? latest?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/daniel-schuermann/mesa/issues/150?email_source=notifications&email_token=AIPVS43BFV26SPM42KQGNDLQ4YW6DA5CNFSM4I74EQLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEINZYRQ#issuecomment-572234822, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIPVS4ZW4TFBS46ODVRDNMLQ4YW6DANCNFSM4I74EQLA .

AwesamLinux commented 4 years ago

@pingubot I tried again with the very latest Oibaf PPA from today, but could not see any glitches with the sky/sandstorms even with ACO enabled.

Assuming 7b444ba is included in that driver, then maybe the sky/sandstorm glitch only occurs with Vega :thinking:

daniel-schuermann commented 4 years ago

This repo here contains a couple of optimizations, so it might very well be the case that we broke something. Could someone provide a capture? Then, I can try to figure what went wrong :)

NTMan commented 4 years ago

@daniel-schuermann please look my report https://gitlab.freedesktop.org/mesa/mesa/issues/2267#note_378824

AwesamLinux commented 4 years ago

I'm closing this issue, as the only remaining problem is the flickering shadow and it appears to be related to Proton and not ACO.

Because it occurs regardless of using LLVM or ACO on new Proton versions, and does not occur with old Proton 4.2-9 as mentioned here https://github.com/ValveSoftware/Proton/issues/410