daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)

http://mesa3d.org

135 stars 3 forks source link

Graphical Issue Star Wars Jedi: Fallen Order #163

Closed gort818 closed 4 years ago

gort818 commented 4 years ago

Game runs great with aco! much less stutter than llvm, but there seems to be a graphical issue with certain characters' hair in the game, this issue was not present with llvm

with aco

Screenshot_20191125_190507

with llvm star-wars-jedi-fallen-order-cal

RenderDoc capture: Could not get a capture, and it takes me forever to get the game to start.. sometimes it takes me twenty minutes but that is beside the point. System information:

GPU: [vega 56]
ACO version: [6df53a980c0]

gort818 commented 4 years ago

So I have to launch the game with origin and if I launch it with ENABLE_VULKAN_RENDERDOC_CAPTURE=1 origin crashes :(

If there is anything else I can do let me know.

pendingchaos commented 4 years ago

Seems someone created a duplicate issue on the Gitlab: https://gitlab.freedesktop.org/mesa/mesa/issues/2156 (the GitHub repo is still the preferred place to report ACO bugs for now)

The reporter somehow got some renderdoc captures and I think they are useful. I'll probably look into it more in the morning

gort818 commented 4 years ago

Ok awesome thanks!

pendingchaos commented 4 years ago

I think this MR should fix the issue: https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2917

pendingchaos commented 4 years ago

Should be fixed with https://github.com/daniel-schuermann/mesa/commit/8a8381dd604c5f0a3b677230d683ed27bcad461c (https://gitlab.freedesktop.org/mesa/mesa/commit/ff70ccad16a2efb3be1fbc4ca03453d38721a267 in upstream)