daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)
http://mesa3d.org
135 stars 3 forks source link

Rage 2: Gpu hang with vsync off and graphical issues #167

Closed pingubot closed 4 years ago

pingubot commented 4 years ago

Describe the bug There are 2 bugs. Using aco leads to a gpu hang if vsync is disabled. Using vsync "soft" let you get in the map, but then there are graphical issues. The gpu hang with vsync off can be mitigated with vk_x11_strict_image_count=true.

Both things don't show up with RADV_PERFTEST=llvm.

Screenshots rage2graphicalissue

RenderDoc capture: https://drive.google.com/open?id=1WNBLt00km1CMZTxpQrocLHNOI3fHoA4z

System information:

Additional context Add any other context about the problem here.

pingubot commented 4 years ago

Any news for that issue ?

pendingchaos commented 4 years ago

Opening the renderdoc, some of it seems corrupted but I think it's unrelated to this issue

Unfortunately, I think the problematic shader was used in a different frame, so the result is baked into the capture and it's unlikely to be useful

Not sure where to go from there. I'll probably look at the capture a bit more but I doubt I'll find much. I think we usually fix these accidentally while working on an unrelated (and more debug-able) issue

daniel-schuermann commented 4 years ago

Didn't rage2 work previously? Maybe we can bisect, but it might very well be that something unrelated just uncovered the issue...

aufkrawall commented 4 years ago

I think the game uses mailbox vsync mode by default on Linux. No idea how this can be related to rendering issues, but what happens when you force vsync off via MESA_VK_WSI_PRESENT_MODE=immediate @pingubot ?

pingubot commented 4 years ago

I think the game uses mailbox vsync mode by default on Linux. No idea how this can be related to rendering issues, but what happens when you force vsync off via MESA_VK_WSI_PRESENT_MODE=immediate @pingubot ?

Using that options shows the same graphical issues.

pingubot commented 4 years ago

@daniel-schuermann , @pendingchaos , the graphical issue are fixed with: mesa-git up to commit 0c4a70b64d6f916ecdf9055b52078bf4f63e7a97 .

In addition, instead of a gpu hang , i now get game crashes with specific vsync combinations. vk_x11_strict_image_count=true + vsync off works.

pendingchaos commented 4 years ago

@pingubot Sorry for the late response. I'll close this issue then

For the crashes, can you open an issue on https://gitlab.freedesktop.org/mesa/mesa/-/issues/ if they still happen?