search

daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)
http://mesa3d.org
135 stars 3 forks source link

Strange Brigade - corruption in faces vs. LLVM #169

Closed aufkrawall closed 3 years ago

aufkrawall commented 4 years ago

native Vulkan game

LLVM: Screenshot_20191229_123716

ACO (grainy and blocky artifacts in her face): Screenshot_20191229_123730

RenderDoc capture: https://drive.google.com/open?id=1CwnQQPyxpmU_smF0ijZNqTwp9TxK06s2

RX 570 8GB mesa-git 20.0.0_devel.118799.ff3a2576a45 (not ACO fork)

aufkrawall commented 4 years ago

Could confirm the same corruption on Navi.

aufkrawall commented 4 years ago

Fixed with this branch 7b444ba5ef1818f81c1892c5babd02ed18186b02 . :) Going to post some numbers in the benchmark ticket that you should like.

pendingchaos commented 4 years ago

More precisely, the commit should be https://github.com/daniel-schuermann/mesa/commit/5d7675a739736450b947b8d51db80ed14567e7c4 (though I might do a different fix in the end)

There are still some subtle differences from LLVM, since that commit doesn't completely fix the issue. I doubt the issue affects performance at all

That commit isn't upstreamed btw

aufkrawall commented 3 years ago

Not reproducible anymore with mesa 20.1.4 & RX 480.