daniel-schuermann / mesa

Mesa 3D graphics library (mirror; no pull requests here please)
http://mesa3d.org
135 stars 3 forks source link

D9VK and Skyrim Legendary Edition: Artefacts with MSAA enabled #88

Closed varris1 closed 5 years ago

varris1 commented 5 years ago

Describe the bug After I enabled 8x MSAA, artefacts appeared ingame. RADV_PERFTEST=llvm didn't show that behavior

Screenshots ACO

LLVM

RenderDoc capture: https://mega.nz/#!H2ghxK6J!Vypi1M1xw-WipOqA87KBmjmNmUkLXblDN-ZPcJixCxg

System information:

Additional context I used Wine & D9VK.

daniel-schuermann commented 5 years ago

it works with https://github.com/daniel-schuermann/mesa/tree/master_old_2019_07_12 I'll check back, when I found out what broke.

daniel-schuermann commented 5 years ago

Actually, it didn't work. The old branch just misses a feature so that some shadows aren't rendered at all. We'll keep you posted.

daniel-schuermann commented 5 years ago

Actually, I think both images are wrong and LLVM just got lucky that it doesn't look so terrible.

Screenshot from 2019-08-03 08-51-34

Can you confirm that this is the expected output?

BNieuwenhuizen commented 5 years ago

So is this really Skyrim Legendary Edition + D9VK, or is this Skyrim Special Edition with DXVK? I see a DXVK HUD on there?

nvm, looks like D9VK also has the same HUD.

FWIW I cannot reproduce this with upstream radv & a vega.

varris1 commented 5 years ago

Can you confirm that this is the expected output?

Gallium Nine Here is a screenshot of Gallium Nine. In hindsight the LLVM image doesn't seem to be correct either.

I will ask @joshua-ashton to take a look at it since it could just be an issue with D9VK itself.

daniel-schuermann commented 5 years ago

FWIW I cannot reproduce this with upstream radv & a vega.

Did you try with PROTON_USE_D9VK=1 ?If I do this, I only get abnormal program termination... but I start to get the impression that this might be a D9VK bug and not the driver.

misyltoad commented 5 years ago

Should be closed by https://github.com/Joshua-Ashton/d9vk/commit/605296b4670340ebf08ff7f81ac3968e8164f00a

'Twas an issue on my end that was not easily apparent visually with LLVM.

varris1 commented 5 years ago

What Josh said.