search

daniel-stoneuk / material-about-library

Makes it easy to create beautiful about screens for your apps
Apache License 2.0
1.12k stars 140 forks source link

ConvenienceBuilder::createVersionActionItem -> without versionCode #15

Closed Rainer-Lang closed 7 years ago

Rainer-Lang commented 7 years ago

I would like to have the version info without versionCode. I could provide a method (PR):

Would do you prefer - and do you support this?

daniel-stoneuk commented 7 years ago

Old method with parameter for sure! I just got home so will be able to make the change myself if that's easier

Rainer-Lang commented 7 years ago

It's up to you - what you prefer. :) I'm just starting to work with your lib....sorry for the many questions.

daniel-stoneuk commented 7 years ago

Don't worry about the questions - you're giving me great ideas. I appreciate it!