search

daniel-stoneuk / material-about-library

Makes it easy to create beautiful about screens for your apps
Apache License 2.0
1.12k stars 140 forks source link

ConvenienceBuilder: WebViewDialog item -> horizontal scrollable #18

Closed Rainer-Lang closed 7 years ago

Rainer-Lang commented 7 years ago

I create a WebViewDialog item and use an url. The opened dialog is horizontal scrollable - on my Nexus5 about 0.5cm This shouldn't happen.

Rainer-Lang commented 7 years ago

And please even "createWebViewDialogItem" with and without subtext. :) And thanks a lot for the changes.

daniel-stoneuk commented 7 years ago

What do you mean it's horizontally scrollable? As in the website in it can scroll up and sideways?

Will make the changes to the WebViewDialogItem 🤣

daniel-stoneuk commented 7 years ago

Ah about the createWebViewDialogItem with and without subText: I probably haven't made this clear enough but you are able to specify null as the subText parameter for no subText to appear. (Hence the @Nullable annotation.

Rainer-Lang commented 7 years ago

With "null" - now I know it. ;) Yes sideways scrollable.

Rainer-Lang commented 7 years ago

btw with AboutLibraries this doesn't happen - if this helps.

daniel-stoneuk commented 7 years ago

Do you think you should be able to zoom it?

daniel-stoneuk commented 7 years ago

Alright so that's that sorted. Anything else you want me to add before I create a release for the changes? 😂

Rainer-Lang commented 7 years ago

AAAHHHHH wait....this and this and that and also here this :-D

daniel-stoneuk commented 7 years ago

I'll take that as a no? 😝😂

Thanks for all your suggestions. I have a habit of releasing things and not testing them - should probably stop doing that.

Rainer-Lang commented 7 years ago

Releasing without testing ... then I'll test it. ;)