search

daniel-stoneuk / material-about-library

Makes it easy to create beautiful about screens for your apps
Apache License 2.0
1.12k stars 140 forks source link

add parameter that icon is always in the upper left corner #25

Closed Rainer-Lang closed 7 years ago

Rainer-Lang commented 7 years ago

I use the html text and the icon is vertically centered, which looks really "strange". Please add a parameter to define if the icon should be vertically centered or in upper left corner.

daniel-stoneuk commented 7 years ago

I'll do that later today when I get the time, sorry for the wait.

On Wed, 11 Jan 2017, 11:46 am Rainer-Lang, notifications@github.com wrote:

I use the html text and the icon is vertically centered, which looks really "strange". Please add a parameter to define if the icon should be vertically centered or in upper left corner.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/daniel-stoneuk/material-about-library/issues/25, or mute the thread https://github.com/notifications/unsubscribe-auth/APIE1Sv1VHqqL9KSr_JqhEbRACjzGTKVks5rRMDjgaJpZM4LgfQ1 .

Rainer-Lang commented 7 years ago

Don't be rushed. You're doing right. 👍 These here are only suggestions, maybe you have another solution and we could discuss...

daniel-stoneuk commented 7 years ago

Use this dependency for now: 

        compile 'com.github.daniel-stoneuk:material-about-library:b8d4ac6b9b'
Rainer-Lang commented 7 years ago

Will try it later or tomorrow.

Rainer-Lang commented 7 years ago

Tested: The icon seems a bit lower than the right action-title-text.

daniel-stoneuk commented 7 years ago

Could you post a screenshot? It looks to be fine here: screenshot

Rainer-Lang commented 7 years ago

The html-icon IS not as high as the action title text - look at your screenshot. BUT it could be that the icon has a "border" with transparent pixel - in the icon itself.

daniel-stoneuk commented 7 years ago

Oh right, I see what you mean. In my opinion that's a tiny detail and is probably in the icon itself so I wouldn't worry.

Rainer-Lang commented 7 years ago

Yes, like I wrote - could be the icon itself.