daniel-stoneuk / material-about-library

Makes it easy to create beautiful about screens for your apps
Apache License 2.0
1.12k stars 140 forks source link

Feature: customization card style #30

Closed Scrounger closed 7 years ago

Scrounger commented 7 years ago

@daniel-stoneuk: Thanks for this great lib! Can you please implement the option to customize the card layout (overriding dimens) and add the follwowing parameters to the card style:

        <item name="android:foreground">?attr/selectableItemBackground</item>
        <item name="cardCornerRadius">4dp</item>
        <item name="cardElevation">4dp</item>
        <item name="cardMaxElevation">4dp</item>
        <item name="cardPreventCornerOverlap">false</item>
        <item name="cardUseCompatPadding">true</item>
daniel-stoneuk commented 7 years ago

Of course - good point about the parameters to the card style. I'm not too sure but I think if you override any of these layouts (by putting them in your app's layout folder) you should be able to change the dimensions - same with.

daniel-stoneuk commented 7 years ago

I've added the parameters, but made sure that they conform to material specs.

Scrounger commented 7 years ago

Perfect, thanks for fast implemnetation. Overriding the layout file is the better option, to get my standard card layout.

daniel-stoneuk commented 7 years ago

No problem! Just make sure there is corresponding views with the correct id's.

Scrounger commented 7 years ago

No problem! Just make sure there is corresponding views with the correct id's.

Could cause a silent exception ;-)