Closed befriendabacterium closed 1 year ago
Oh great it's failing everything now :sweat_smile: even worse than last time. Eyeballing the error messages it seems to be having trouble installing orchaRd :thinking:
Ha, happens. If you use devtools::check()
and devtools::tests()
you should be able to narraow the issues down
Ha, happens. If you use
devtools::check()
anddevtools::tests()
you should be able to narraow the issues down
Hi Dan - sorry but I'm not really understanding. orchaRD is installed fine my end, it's just when I make the pull request on GitHub these issues arise. I am completely unsure how these checks are working but it seems to be something with the installation of orchaRd on the virtual machine the checks are running off, in my very naive understanding?
Alright with help of a friend @padpadpadpad think have figured out the error and implemented some other corrections to actually get it working...famous last words 🤞
You need to re-run devtools::document() to make sure the help page has your new parameter in.
Patch coverage: 40.00%
and project coverage change: -0.17%
:warning:
Comparison is base (
e837246
) 60.48% compared to head (49f4b4e
) 60.32%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
seems to be running ok now just codecov couldn't check some lines I added but I think OK to merge pending one last brief check from you?
@befriendabacterium This is looking good on my end so I'll merge. Thanks for adding that, and thanks @padpadpadpad for clarifying to Matt on what to do.
-Added @param with documentation -Added error handler - if user specifies order of incorrect length, stops function and throws error