daniel1noble / orchaRd

Extending the Orchard Plot for Meta-analysis
https://daniel1noble.github.io/orchaRd/
11 stars 6 forks source link

Documentation and error handling for 'tree.order' option #41

Closed befriendabacterium closed 1 year ago

befriendabacterium commented 1 year ago

-Added @param with documentation -Added error handler - if user specifies order of incorrect length, stops function and throws error

befriendabacterium commented 1 year ago

Oh great it's failing everything now :sweat_smile: even worse than last time. Eyeballing the error messages it seems to be having trouble installing orchaRd :thinking:

daniel1noble commented 1 year ago

Ha, happens. If you use devtools::check() and devtools::tests() you should be able to narraow the issues down

befriendabacterium commented 1 year ago

Ha, happens. If you use devtools::check() and devtools::tests() you should be able to narraow the issues down

Hi Dan - sorry but I'm not really understanding. orchaRD is installed fine my end, it's just when I make the pull request on GitHub these issues arise. I am completely unsure how these checks are working but it seems to be something with the installation of orchaRd on the virtual machine the checks are running off, in my very naive understanding?

befriendabacterium commented 1 year ago

Alright with help of a friend @padpadpadpad think have figured out the error and implemented some other corrections to actually get it working...famous last words 🤞

padpadpadpad commented 1 year ago

You need to re-run devtools::document() to make sure the help page has your new parameter in.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.17% :warning:

Comparison is base (e837246) 60.48% compared to head (49f4b4e) 60.32%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #41 +/- ## ========================================== - Coverage 60.48% 60.32% -0.17% ========================================== Files 9 9 Lines 615 620 +5 ========================================== + Hits 372 374 +2 - Misses 243 246 +3 ``` | [Files Changed](https://app.codecov.io/gh/daniel1noble/orchaRd/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Noble) | Coverage Δ | | |---|---|---| | [R/orchard\_plot.R](https://app.codecov.io/gh/daniel1noble/orchaRd/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Noble#diff-Ui9vcmNoYXJkX3Bsb3QuUg==) | `71.77% <40.00%> (-1.34%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

befriendabacterium commented 1 year ago

seems to be running ok now just codecov couldn't check some lines I added but I think OK to merge pending one last brief check from you?

daniel1noble commented 1 year ago

@befriendabacterium This is looking good on my end so I'll merge. Thanks for adding that, and thanks @padpadpadpad for clarifying to Matt on what to do.