search

daniel1noble / orchaRd

Extending the Orchard Plot for Meta-analysis
https://daniel1noble.github.io/orchaRd/
11 stars 6 forks source link

Ability to plot just the data (without the model fit) in bubble_plot() #50

Open befriendabacterium opened 9 months ago

befriendabacterium commented 9 months ago

Is your feature request related to a problem? Please describe. Good to have this option so can easily produce equivalent plots without model fit, especially where a model wasn't fit/able to be fit/was poor/non-sig for certain subsets of the data you're presenting, and you therefore may not want to show the model fit on some plots.

Describe the solution you'd like Option to provide a dataframe as bubble_plot()'s 'object' argument, and it to plot without this.

Describe alternatives you've considered Could remove model fits manually via +'ing a ggplot line maybe? But doesn't solve issue where I model wasn't fit/couldn't be fit (since there's no model object to fit).

Additional context I already made some preliminary edits to bubble_plot() to solve this, just making this feature request for housekeeping purposes/in case edits are needed.

befriendabacterium commented 9 months ago

Here's my proposed solution...https://github.com/befriendabacterium/orchaRd/tree/justdata

befriendabacterium commented 9 months ago

And pull request for it...though might be a bit early as quite a few edits i've made and you'll likely want to review for style and do a bit more robustness testing. Let me know if you need a hand! https://github.com/daniel1noble/orchaRd/pull/51