search

daniel5151 / gdbstub

An ergonomic, featureful, and easy-to-integrate implementation of the GDB Remote Serial Protocol in Rust (with no-compromises #![no_std] support)
Other
291 stars 45 forks source link

Clippy warnings in library code #114

Closed geigerzaehler closed 1 year ago

geigerzaehler commented 1 year ago

When I run cargo clippy --lib in the existing code base I see a couple of warnings although the pull request template asks me to check that there are no clippy warnings. It looks like CI does not run clippy for the library target.

daniel5151 commented 1 year ago

Could you post a screenshot / test output of what warnings you're seeing? I just ran cargo clippy locally and I'm not seeing what you're talking about.

geigerzaehler commented 1 year ago

I saw this issue on the dev/0.7 branch at commit b8625991d71a668787f56db4a6afe0fc3e6cb7e4 but they are fixed now. It might be a good idea to run clippy for all targets on CI.

daniel5151 commented 1 year ago

Hmm, weird...

My Github Actions-fu isn't all that great. If you'd like to take a stab at pushing up a CI fix PR, I'd be happy to merge it in. Otherwise, I'll close this for now :)