danieladov / jellyfin-plugin-themesongs

Downloads TV Show Theme Songs for your library
MIT License
82 stars 6 forks source link

[Feature Request] Jellyfin 10.9 compatibility #34

Closed foux closed 4 months ago

foux commented 4 months ago

Hi there, just a note to keep the plugin compatible with Jellyfin 10.9.

Here are the error loading the plugin on 10.9 :

[2024-05-11 21:47:28.415 +02:00] [ERR] [1] Emby.Server.Implementations.Plugins.PluginManager: Failed to load assembly "/config/data/plugins/Theme Songs_10.8.0.1/Jellyfin.Plugin.ThemeSongs.dll". This error occurs when a plugin references an incompatible version of one of the shared libraries. Disabling plugin
System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types.
Could not load type 'MediaBrowser.Controller.Plugins.IServerEntryPoint' from assembly 'MediaBrowser.Controller, Version=10.9.0.0, Culture=neutral, PublicKeyToken=null'.
   at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
   at System.Reflection.RuntimeModule.GetTypes()
   at Emby.Server.Implementations.Plugins.PluginManager.LoadAssemblies()+MoveNext()
System.TypeLoadException: Could not load type 'MediaBrowser.Controller.Plugins.IServerEntryPoint' from assembly 'MediaBrowser.Controller, Version=10.9.0.0, Culture=neutral, PublicKeyToken=null'.

Running on jellyfin official docker image

Thanks

ReenigneArcher commented 4 months ago

Just linking this here for the maintainer in case it will help them. https://github.com/LizardByte/Themerr-jellyfin/pull/314

As I learned a lot from this plugin, while creating my Themerr-jellyfin plugin, the least I can do is share my solution.

yamanobe96 commented 4 months ago

This wonderful and historic program has unfortunately stopped working due to Jellyfin's update to 10.9. I can't breathe without this program working

nylimited commented 4 months ago

Are there plans to update this plugin for the current Jellyfin release?

danieladov commented 4 months ago

I've just released an update

ReenigneArcher commented 4 months ago

Should this be updated as well? https://github.com/danieladov/jellyfin-plugin-themesongs/blob/0dcdfcdc9d58f21ff8f5f031ac03222e29715711/build.yaml#L5

danieladov commented 4 months ago

Should this be updated as well?

https://github.com/danieladov/jellyfin-plugin-themesongs/blob/0dcdfcdc9d58f21ff8f5f031ac03222e29715711/build.yaml#L5 That file is for compiling the plugin, but I'm not using it. I should have deleted it, to be honest.

yamanobe96 commented 4 months ago

Thank you for updating. Your plugins have helped me a lot.