search

danielamitay / DAKeyboardControl

DAKeyboardControl adds keyboard awareness and scrolling dismissal (ala iMessages app) to any view with only 1 line of code.
Other
1.58k stars 214 forks source link

Only inject inputAccessoryView if textView isEditable. #67

Closed plu closed 10 years ago

plu commented 10 years ago

There's a bug in UIKit that would fire a UIKeyboard(Will|Did)ShowNotification when a UITextView is readonly (textView.editable = NO;) but has a inputAccessoryView. See also: http://openradar.appspot.com/radar?id=5306932189462528

To work around this issue, DAKeyboardControl should only inject a inputAccessoryView if the UITextView actually isEditable.

plu commented 10 years ago

Thanks :+1:

danielamitay commented 10 years ago

No, thank you!

jeffdav commented 10 years ago

Thanks to both of you; this solves an issue I have with UITextViews in a UICollectionView and HPGrowingTextView. Will you be updating the podspec soon, or I shall I just point mine at master for the time being?

danielamitay commented 10 years ago

I will update the podspec over the weekend :thumbsup:

jeffdav commented 10 years ago

Thanks.