Fixes deprecated numpy.float; adds numpy.double.

danielapai / bioverse

A simulation framework to assess the statistical power of future biosignature surveys

MIT License

7 stars 5 forks source link

Fixes deprecated numpy.float; adds numpy.double. #24

Closed Ahmed-Z-D closed 12 months ago

Ahmed-Z-D commented 1 year ago

This pull request fixes #23 by removing the deprecated numpy.float alias from constants.py Additionally, I have included a new alias numpy.double as a replacement, which represents the 64-bit floating-point data type and is equivalent to numpy.float64.

With these changes, the code will be updated to use the recommended aliases for the appropriate data type, and the deprecated alias will be removed.

matiscke commented 12 months ago

@Ahmed-Z-D we are very sorry for the long delay. Feel free to re-open this PR, which indeed would be a fix of the issue. Thanks so much for contributing!

Ahmed-Z-D commented 12 months ago

@matiscke, thank you for your suggestion to reopen this pull request. Following your suggestion, this PR has been reopened.

matiscke commented 12 months ago

There were some other incompatibilities among pandas, astropy, and numpy >= 1.20. The additional commits should fix those.

matiscke commented 12 months ago

Thanks a lot, @Ahmed-Z-D!