danielapai / bioverse

A simulation framework to assess the statistical power of future biosignature surveys
MIT License
7 stars 6 forks source link

Example 2: Detecting the age-oxygen correlation is broken #36

Closed matiscke closed 1 year ago

matiscke commented 1 year ago

The first plot in the notebook doesn't show any planets. As it turns out, no oxygen is being measured (column 'has_O2' exists in the generated sample and has positive entries, but it is all nan in the observed data).

matiscke commented 1 year ago

@kevinkhu and I suspect that lines 901 through 908 in functions.py cause this bug. Semimajor axis and eccentricity gets overwritten.

A fix is in the making!