danielapai / bioverse

A simulation framework to assess the statistical power of future biosignature surveys
MIT License
7 stars 5 forks source link

Fix nan measurements #57

Open matiscke opened 3 months ago

matiscke commented 3 months ago

There is an issue with measuring observables that contain nan values. For example, if the new HPIC star catalog is used to generate stars (see #53 ), a cryptic error message appears when a survey is conducted with this generator (e.g. survey.quickrun).

The reason seems to be that the "age" column contains lots of nans and this is currently not well handled in utils.normal().

This PR aims to fix this. I started working on this fix, but my preliminary solution breaks stuff elsewhere (now the assign_mass step in the generator throws a "TypeError: 'float' object is not subscriptable".

I need to stop now, anyone is welcome to contribute or brainstorm.