Closed hongweipeng closed 2 years ago
We have test coverage for gcc 4.8, but for 4.8.5. There were a lot of gcc bugs fixed between 4.8.1 and 4.8.5.
Does your code still compile with gcc 4.8.2 if you change
int_type overflow( int_type ch = std::streambuf::traits_type::eof() ) override
{
return ch;
}
to
int_type overflow( int_type ch = typename std::basic_streambuf<CharT>::traits_type::eof() ) override
{
return ch;
}
?
After the change, it can be compiled.
Oh sorry, didn't notice that your change is different from the one in the PR. I'll try it tomorrow to see if your changes compile.
It can be compile in gcc 4.8.2 when using typename std::basic_streambuf<CharT>::traits_type::eof()
.
Okay, if you update your pull request to that, I'll accept it.