danielaparker / jsoncons

A C++, header-only library for constructing JSON and JSON-like data formats, with JSON Pointer, JSON Patch, JSON Schema, JSONPath, JMESPath, CSV, MessagePack, CBOR, BSON, UBJSON
https://danielaparker.github.io/jsoncons
Other
699 stars 158 forks source link

Change signature of dump_pretty #438

Closed ergonjomeier closed 1 year ago

ergonjomeier commented 1 year ago

After updating to 0.171.0, our code failed to compile with the following error:

.../jsoncons/basic_json.hpp:3866:13: error: no matching member function for call to 'dump_pretty' dump_pretty(cont, options, indent, ec);

The error occurs because on line 3866, dump_pretty is called with 4 parameters, but a dump_pretty function with the corresponding signature does not exists. After looking into the issue (and reading the doc https://github.com/danielaparker/jsoncons/blob/master/doc/ref/corelib/json/dump.md), I think that a dump_pretty function that takes an indent parameter should not exist at all.

I am not entirely sure how to fix this. The docs say that there should be a dump_pretty function that takes a CharContainer and options, with the options having a default parameter. My proposition changes the functions signature to fit the docs.

danielaparker commented 1 year ago

Thanks for fixing this!

ergonjomeier commented 1 year ago

Glad I could help :-)