search

danielbarter / mini_compile_commands

GNU General Public License v3.0
37 stars 3 forks source link

Does it make sense to include NIX_CFLAGS_COMPILE in the output? #4

Closed expipiplus1 closed 12 months ago

expipiplus1 commented 1 year ago

Since clangd is itself savvy to this variable, putting these in the output results in them being present twice in the eventual compilation inside clangd. (Any other LSP tools should also be aware of these on nix).

danielbarter commented 1 year ago

Having duplicate commands in the output doesn't matter for use with clangd. We are very careful to capture everything, and I am afraid that trying to exclude certain arguments would result in things slipping through the cracks.

It would be possible to remove duplicates before writing to json

danielbarter commented 12 months ago

Closing, since IMO for the intended use case this is a non issue.