search

danielbayerlein / honeycomb

🐝 Honeycomb is a common basis for @nodejs microservices
MIT License
10 stars 0 forks source link

Global assets #80

Closed chrishelgert closed 7 years ago

chrishelgert commented 7 years ago

@danielbayerlein i use localhost for the asset-service. if i look at the examples from zalando, i think we will need amd (require.js) for the fragment-usage. let´s look at this in a further step.

Update: i created an issue #81 - to handle the combination of asset-service with example-react

codecov-io commented 7 years ago

Current coverage is 96.61% (diff: 85.71%)

Merging #80 into master will decrease coverage by 3.38%

@@           master        #80   diff @@
========================================
  Files           7          9     +2   
  Lines          45         59    +14   
  Methods        10         12     +2   
  Messages        0          0          
  Branches        4          5     +1   
========================================
+ Hits           45         57    +12   
- Misses          0          2     +2   
  Partials        0          0

Powered by Codecov. Last update 9396cc4...3643f34

chrishelgert commented 7 years ago

@danielbayerlein i did the changes :)