search

danielbayerlein / honeycomb

🐝 Honeycomb is a common basis for @nodejs microservices
MIT License
10 stars 0 forks source link

#67 Moved route in info- and healh-controller into /admin - scope #93

Closed chrishelgert closed 7 years ago

chrishelgert commented 7 years ago

changed the remaining intern-routes to the /admin-scopes. the rest will handle currently out lb. we can think about oauth and co for this routes later if we really need it, or what do you think?

danielbayerlein commented 7 years ago

Please also update the honeycomb-registry-client.

-    statusPageUrl: `http://${host}:${port}/info`,
-    healthCheckUrl: `http://${host}:${port}/health`,
+    statusPageUrl: `http://${host}:${port}/admin/info`,
+    healthCheckUrl: `http://${host}:${port}/admin/health`,

Add the endpoint information to the honeycomb-info-middleware and honeycomb-health-middleware readme.

honeycomb-info-middleware:

+## Endpoint
+
+`/admin/info`
+
## Usage

honeycomb-health-middleware:

+## Endpoint
+
+`/admin/health`
+
## Usage
codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #93 into master will not change coverage

@@           master   #93   diff @@
===================================
  Files          11    11          
  Lines          77    77          
  Methods        15    15          
  Messages        0     0          
  Branches       11    11          
===================================
  Hits           77    77          
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 9faa59d...c899f49

chrishelgert commented 7 years ago

@danielbayerlein ✔️

danielbayerlein commented 7 years ago

👍