danielbergholz / techschool.dev

TechSchool is a curated list of free programming courses from YouTube
https://techschool.dev
MIT License
275 stars 26 forks source link

Add "no courses that match search results" text and remove the "load more" button when nothing matches the search/category query. #35

Closed Ragudos closed 7 months ago

Ragudos commented 8 months ago

Screenshot_2024-03-07-15-54-56-35_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

lcezermf commented 8 months ago

Hey, can I pick this? @Ragudos @danielbergholz

Ragudos commented 8 months ago

It's fine for me. I suggest waiting for @danielbergholz to respond since I'm new in this repo.

danielbergholz commented 8 months ago

Sure @lcezermf, that would be great! LMK if you have any questions 🤝

lcezermf commented 8 months ago

NP. I will dig into the code a little more and do a draft PR until the next week.

danielbergholz commented 8 months ago

Awesome @lcezermf, thank you!

lcezermf commented 8 months ago

@danielbergholz I started working on something, just wanna check something the idea is to keep using stream to hold the courses within the search page, correct? Is there any advantage over using the regular assign(socket, :data, values)?

danielbergholz commented 8 months ago

Some people say it's better for memory usage, especially when dealing with lots of records from the DB, but I'm open to suggestions

lcezermf commented 8 months ago

Not a problem! I was just curious cause I have never used that before (my current project uses a lower version) and I got the unit tests working but the feature feels odd cause seem the result on the page never get "empty", but I will try a little more with streams and see how it goes.