search

danielberkompas / elasticsearch-elixir

No-nonsense Elasticsearch library for Elixir
MIT License
422 stars 73 forks source link

Support runtime configuration via {:system, _} tuple #77

Closed ImmaculatePine closed 2 years ago

ImmaculatePine commented 5 years ago

Currently it is not obvious that one can override MyApp.Cluster.init/1 for runtime configuration unless you read the source code. So, I did 2 changes there:

  1. Added support for more idiomatic {:system, _} tuple
  2. Added description of both configuration methods to readme
christianjgreen commented 4 years ago

Added support for more idiomatic {:system, _} tuple System tuples are heavily frowned upon

danielberkompas commented 2 years ago

I would prefer to just document that you can use MyApp.Cluster.init for this, rather than support {:system, _} tuples at this point.