Replace sparkJava dependency with Spring boot

danielbinder / LogiVis

A teaching aid for concepts and algorithms in logic

MIT License

2 stars 0 forks source link

Replace sparkJava dependency with Spring boot #29

Closed danielbinder closed 7 months ago

danielbinder commented 9 months ago

SparkJava has not been updated in some time (last commit to the repo was 2 years ago). We want to 1) Avoid vulnerabilities 2) Allow for native compiling (with GraalVM) without any of the weirdness sparkjava produces

Tasks:

Remove the sparkjava from dependency from gradle and replace it with spring boot
Make sure, that all RestEndpoints (currently Servlet and AlgorithmTester) still work.
Make sure static file hosting here still works i.e. that the frontend can be started like this

danielbinder commented 8 months ago

Currently working:

Hosting of most GET methods
Serving of frontend

Current NOT working:

Pasting in a URL
Some get methods seem to be called with 'bad requests' - especially the methods where models are sent over

Remaining TODOs beyond that:

Spring boot can probably replace shadowJar, if frontend hosting works out of the .jar
Adapt run configurations