danielbrendel / hortusfox-web

Self-hosted collaborative plant management system for your local environment
https://hortusfox.github.io
MIT License
495 stars 25 forks source link

Main plant photo ends up off-centered #185

Open averymd opened 2 months ago

averymd commented 2 months ago

I'm very new to HF, so this could definitely be user error! When I upload a photo as the main photo for a plant on mobile or desktop, only the left portion of the photo is shown in the regular view:

image

image

and the aspect ratio is busted when the photo is expanded: image

Photos uploaded to the bottom section of the plant page look just fine: image

Steps to reproduce the behavior:

  1. On either desktop or mobile, go to a plant and choose to upload a photo in the main spot.
  2. Choose a photo (I've used a 2.4 MB photo and a 550 KB photo) and upload it
  3. After upload, the default view and expanded view will have the problem

Expected behavior I'd at least expect the photo to stay centered, but if some subject-detecting code is involved to choose the portrait slice, then it might need a little guidance. Alternately, HF could state the dimensions we should crop our images to before uploading.

Desktop:

Smartphone:

danielbrendel commented 2 months ago

Hi,

thank you for your bug report.

This is indeed something I need to fix. I'll add that to the 3.1 milestone. For now it is recommended to use portrait orientation for the main photo.

Kind regards