danielbrendel / hortusfox-web

Self-hosted collaborative plant management system for your local environment
https://hortusfox.github.io
MIT License
594 stars 33 forks source link

Weather Information Errors #190

Closed Starstrike closed 4 months ago

Starstrike commented 4 months ago

Describe the bug Tried to use the new OpenWeatherMap functionality and I entered an API key I already had, but wouldn't get any results. I generated a new API key to enter and got what is shown in the screenshots.

First screenshot is with my API key I already had. The city is correct, just redacted. Second screenshot is when I entered a new API key that I just generated.

To Reproduce Steps to reproduce the behavior:

  1. Go to openweathermap
  2. Generate a new API key
  3. Enter new API key on HortusFox
  4. Get geolocation.
  5. Save.
  6. Go to Weather button at the top.

Expected behavior What should happen is me seeing the weather forecast.

Screenshots image image

Software:

Desktop (please complete the following information):

danielbrendel commented 4 months ago

Hi, thank you for your bug report.

How long did you wait before using a new generated API key? For me it took about 2-3 hours for it to be activated.

What output do you get if you paste this in your browser?

http://api.openweathermap.org/data/2.5/forecast?appid=YOUR_NEW_API_KEY&lat=YOUR_LATITUDE&lon=YOUR_LONGITUDE&units=YOUR_UNIT_TYPE

Unit type can be default, metric or imperial.

Starstrike commented 4 months ago

I just created a new one since I deleted the new one I had made. I'll wait for a couple hours to check it again.

I did check with my existing key and it does show me results, but in HortusFox, all I get is what's in the first screenshot in my original post.

Starstrike commented 4 months ago

Ok, the new API is now populating info on that link you gave. The errors from the second screenshot are gone, but I'm still seeing what's in the first screenshot, no data.

Starstrike commented 4 months ago

In case it matters, when I first load up the site and I'm on the Dashboard, the weather does show there. So it seems like the issue is on the actual new weather page from the button at the top.

danielbrendel commented 4 months ago

I found out what's the issue and just published a fix. The problem is differing timezones. In some situations it can happen that your workspace uses a wrong timezone. I got this also when hosting workspaces for some of my friends. So now I published a fix that you can specify the timezone in the admin dashboard. There is a dropdown where you can choose from several timezones.

It would be great if you could try the recent update (preferably in a testing environment).

danielbrendel commented 4 months ago

@Starstrike I'll close this issue for now due to it being resolved. If anything occurs nonetheless, feel free to post here so I can reopen the issue.

Starstrike commented 4 months ago

I don't see that 3.1 has been completed yet and that this was added to the milestone. I have watchtower looking for updates to this so as soon as 3.1 is available, I'll have it. Thanks for lookin' into this!

kenske commented 1 week ago

Still seeing this issue on 3.4. I checked the timezone setting in the admin dashboard and it's set to my correct timezone.