search

danielcaldas / react-d3-graph

Interactive and configurable graphs with react and d3 effortlessly
https://danielcaldas.github.io/react-d3-graph/sandbox/
MIT License
818 stars 233 forks source link

Support for d3 v6 #365

Open Tom-Davidson opened 4 years ago

Tom-Davidson commented 4 years ago

Is your feature request related to a problem? Please describe. On initial testing it's mostly the zoom and drag stuff that doesn't work because the nodelist isn't passed, not sure if that's because some events have had a breaking change. I appreciate v6 is only a week old at this point so a feature request rather than a bug. It stumped me for a while why it wasn't working for me as d3 is a per dependancy and I didn't read the version requirements (silly me). Raising this for visibility.

Describe the solution you'd like Support for the v6

Describe your use case Ongoing support for d3

Describe alternatives you've considered Have pinned d3 for the moment but for onwards compatibility with the key dependancy.

Additional context none

gargakshit commented 4 years ago

What version of d3 did you pin? I am having issues with v6.1.1 (which is v6)

Tom-Davidson commented 4 years ago

I pinned 5.16.0 of d3 which seemed to be the last of the 5.x series.

craigpalermo commented 3 years ago

Thank you, @Tom-Davidson! I've been trying to figure out the source of Uncaught TypeError: _d3Selection.event is undefined errors that only seemed to occur when zooming via mouse wheel, even though our zoom-related config didn't differ from the defaults. Downgrading to d3@^5.16 solved the issue.

JaviCodess commented 2 years ago

i downgraded it to 5.16 and doesnt work. my package.json "d3": "^5.16.0", "d3-drag": "^3.0.0", "d3-force": "^3.0.0", "d3-shape": "^3.1.0", "d3-zoom": "^3.0.0", "react": "^18.2.0", "react-d3-graph": "^2.6.0",