danielcaldas / react-d3-graph

Interactive and configurable graphs with react and d3 effortlessly
https://danielcaldas.github.io/react-d3-graph/sandbox/
MIT License
819 stars 233 forks source link

Graph looks different with same data #532

Open vardhan-saniko opened 2 years ago

vardhan-saniko commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

This is the issue I have raised in stack-overflow. https://stackoverflow.com/questions/72818388/react-d3-graph-renders-differently-for-same-data

I have a component that renders react D3 graph. And I have a switch that displays graph1 when its ON and displays graph2 when its OFF.

Basically there was react conditional rendering based on one variable state.

Issue is: graph1 is appearing differently. When component loads first time, it looks different. When switch is OFF(graph2) and then again ON(graph1), now it looks different. I prefer first graph.

Expected behavior Graph should look the same when there is exactly the same data

Screenshots

Screen Shot 2022-06-30 at 8 02 28 AM Screen Shot 2022-06-30 at 8 02 42 AM

Environment:

radhakpr commented 1 year ago

Is it resolved?I am also facing same issue

Sahilcf commented 11 months ago

is it resolved ?

vardhan-saniko commented 11 months ago

No, it is not. I found it as a limitation of read-d3-graph. If the state changes and re-renders, the location of nodes are changing.

We should load the graph with a different key whenever re-rendering happens

Ex: