search

danielcasto / Python-Ray-Tracer-Engine

A simple ray tracer made in pure python
MIT License
0 stars 0 forks source link

Refactor code to be more readable/more practical #7

Open danielcasto opened 2 years ago

danielcasto commented 2 years ago

Add all source files to a dir called src.

danielcasto commented 2 years ago

See if there is a more readable/ more practical way of doing get_solutions in Camera. Make sure to account for light calculations as well.

danielcasto commented 2 years ago

Statically type all variable definitions (where possible).

danielcasto commented 2 years ago

Give privately used functions a name with "_" or "__" as a prefix.

danielcasto commented 2 years ago

Only use ray_size to define shape of Rays. Don't keep it as class var. Initialize rays as empty np array in init.