search

danielcranney / profileme-dev

Create an awesome GitHub profile in minutes
http://profileme.dev/
825 stars 136 forks source link

Adding Kubernetes icon #149

Open DhayalanJazz opened 6 months ago

DhayalanJazz commented 6 months ago

@danielcranney This Change resolves #146 by adding the kubernetes icon . Please tick off Kubernetes in the featured list of #92 issue once the changes are merged.

Note: I added the original "kubernetes-colored.svg" for both light and dark as it will be suitable for all the modes.

Please leave a feedback on this change so that I can improve on adding more icons in future.

vercel[bot] commented 6 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @danielcranney on Vercel.

@danielcranney first needs to authorize it.

danielcranney commented 6 months ago

@danielcranney This Change resolves #146 by adding the kubernetes icon . Please tick off Kubernetes in the featured list of #92 issue once the changes are merged.

Note: I added the original "kubernetes-colored.svg" for both light and dark as it will be suitable for all the modes.

Please leave a feedback on this change so that I can improve on adding more icons in future.

Thanks for the contribution @DhayalanJazz. If you take a look at the README, it will guide you through how to make the icon variants needed to add it to the project. Let me know if you don't have access to software to do this, and I can do it before merge.

DhayalanJazz commented 6 months ago

@danielcranney This Change resolves #146 by adding the kubernetes icon . Please tick off Kubernetes in the featured list of #92 issue once the changes are merged. Note: I added the original "kubernetes-colored.svg" for both light and dark as it will be suitable for all the modes. Please leave a feedback on this change so that I can improve on adding more icons in future.

Thanks for the contribution @DhayalanJazz. If you take a look at the README, it will guide you through how to make the icon variants needed to add it to the project. Let me know if you don't have access to software to do this, and I can do it before merge.

@danielcranney Thank you for your response. I have followed all the instructions on Readme. Unfortunately, I don't have access to adobe Illustrator to make dark and Light Variations, but I have followed the rest of the coding standards. For Future icons, I will try to make dark and light variants leveraging Figma, but for Kubernetes, the coloured icon suits both light and dark modes.