search

danielcranney / profileme-dev

Create an awesome GitHub profile in minutes
http://profileme.dev/
969 stars 152 forks source link

fix: Preserve longDescription paragraphs in Markdown #178

Open LachyTech opened 3 months ago

LachyTech commented 3 months ago

This patch preserves paragraphs entered in the longDescription field by converting each line to <p> elements in HTML, which is converted to a paragraph in markdown via the touchdown service.

Only lines with non-whitespace characters are displayed in the preview.

I considered enclosing the longDescription field in <pre> tags as a simpler approach but single linebreaks wouldn't appear as paragraphs in markdown which is counter-intutive for a non-markdown user.

Related issue: https://github.com/danielcranney/profileme-dev/issues/177

HTML Preview image

markdown preview: image

vercel[bot] commented 3 months ago

@LachyTech is attempting to deploy a commit to the danielcranney's projects Team on Vercel.

A member of the Team first needs to authorize it.